Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDL tool automation to official build #2400

Closed
dagood opened this issue Oct 25, 2019 · 4 comments
Closed

Add SDL tool automation to official build #2400

dagood opened this issue Oct 25, 2019 · 4 comments
Assignees
Milestone

Comments

@dagood
Copy link
Member

dagood commented Oct 25, 2019

The goal is to get policheck and credscan integrated for 3.1.

CoreFX impl: dotnet/corefx#40294 (small fix dotnet/corefx#41993).

@dagood dagood self-assigned this Oct 25, 2019
@dagood dagood changed the title Add SDL tool automation tooling to official build Add SDL tool automation to official build Oct 25, 2019
@dagood
Copy link
Member Author

dagood commented Oct 25, 2019

I (basically) copied what CoreFX has and ran a build, and the SDL step failed due to disk space while trying to pull down artifacts: https://dev.azure.com/dnceng/internal/_build/results?buildId=402553&view=results. Looking at how to change the agent pool it runs on.

I'm also looking at what values are needed for a few of the parameters to the tool. (Notification alias, TSA admin alias.) I haven't gotten to a point in the SDL runs where they're needed yet.

Number of unknowns seems fairly bounded, but could be peeling an onion after getting the disk space issue fixed.

@dagood
Copy link
Member Author

dagood commented Oct 28, 2019

Filed dotnet/arcade#4216 for the disk space issue. It doesn't appear to be configurable, so I'm trying builds with the eng/common job hacked up to see what fix we need.

@dagood
Copy link
Member Author

dagood commented Oct 28, 2019

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the 3.1 milestone Jan 30, 2020
@dagood dagood removed the Triaged label Jan 30, 2020
@dagood
Copy link
Member Author

dagood commented Feb 13, 2020

Done in 3.1 by dotnet/core-setup#8990. Tracked in master by #1027.

@dagood dagood closed this as completed Feb 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants