Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Optimize FindFirstCharToEncode for JavaScriptEncoder.Default using Ssse3 intrinsics #42073

Merged
merged 36 commits into from
Nov 3, 2019
Merged

Optimize FindFirstCharToEncode for JavaScriptEncoder.Default using Ssse3 intrinsics #42073

merged 36 commits into from
Nov 3, 2019

Commits on Oct 17, 2019

  1. Use Sse2 instrinsics to make NeedsEscaping check faster for large 

    strings.
    @ahsonkhan
    ahsonkhan committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    bb040e0 View commit details
    Browse the repository at this point in the history

  2. Update the utf-8 bytes needsescaping and add tests.

    @ahsonkhan
    ahsonkhan committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    b7dbe9d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/dotnet/corefx into Improv… 

    …eEscapingCheck
    @ahsonkhan
    ahsonkhan committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    405cb89 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Remove unnecessary bitwise OR and add more tests

    @ahsonkhan
    ahsonkhan committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    f454359 View commit details
    Browse the repository at this point in the history

  2. Add more tests around surrogates, invalid strings, and characters > 

    short.MaxValue.
    @ahsonkhan
    ahsonkhan committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    477b642 View commit details
    Browse the repository at this point in the history

  3. NeedsEscaping-check with bitmasks

    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    c6c78a4 View commit details
    Browse the repository at this point in the history

  4. char-input uses byte-codepath

    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    cfacc85 View commit details
    Browse the repository at this point in the history

  5. Minimize overhead

    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    ea2a4ba View commit details
    Browse the repository at this point in the history

  6. Renamed NeedsEscapingSsse3 to CreateEscapingMaskSsse3 to be in sync w… 

    …ith CreateEscapingMaskSse2 (renamed from CreateEscapingMask)
    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    734f92e View commit details
    Browse the repository at this point in the history

  7. Added comments for the bit-mask

    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    9cba98a View commit details
    Browse the repository at this point in the history

  8. Rewritten to use pointer arithmetic

    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    48c7483 View commit details
    Browse the repository at this point in the history

  9. Perf-tuning and processing of the remainder vectorized when above a t… 

    …hreshould
    @gfoidl
    gfoidl committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    b3732bc View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Bug fix

    @gfoidl
    gfoidl committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    9fdc85a View commit details
    Browse the repository at this point in the history

  2. Move using directive within ifdef to make it clear when its used.

    @ahsonkhan
    ahsonkhan committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    0f1ddcb View commit details
    Browse the repository at this point in the history

  3. Overhead minimized

    @gfoidl
    gfoidl committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    887d605 View commit details
    Browse the repository at this point in the history

  4. Add more tests for custom text encoder case.

    @ahsonkhan
    ahsonkhan committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    e8895e0 View commit details
    Browse the repository at this point in the history

  5. Fix typo in comment gaurd -> guard

    @ahsonkhan
    ahsonkhan committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    7693801 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into ImproveEscapingCheck

    @gfoidl
    gfoidl committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    590f52a View commit details
    Browse the repository at this point in the history

  7. Fix up the using directives that got removed during merge conflict 

    resolution.
    @ahsonkhan
    ahsonkhan committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    51a837f View commit details
    Browse the repository at this point in the history

  8. Applied code from iteration in S.T.Json to S.T.E.Web 

    I.e. code at 887d605
    @gfoidl
    gfoidl committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    fdc254c View commit details
    Browse the repository at this point in the history

  9. TextEncoder.DoesAsciiNeedEncoding reduced to plain lookup 

    Cf. #41933 (comment)
    @gfoidl
    gfoidl committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    a513077 View commit details
    Browse the repository at this point in the history

  10. Removed System.Runtime.Intrinsics from S.T.Json 

    Somehow this reference was left there, it's not needed anymore.
    @gfoidl
    gfoidl committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    4766c0f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Fixed build-failure 

    System\Text\Encodings\Web\Ssse3Helper.cs(101,13): error SA1115: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameter should begin on the line after the previous parameter.
    @gfoidl
    gfoidl committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    3c5127a View commit details
    Browse the repository at this point in the history

  2. Revert "TextEncoder.DoesAsciiNeedEncoding reduced to plain lookup" 

    This reverts commit a513077.
    @gfoidl
    gfoidl committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    af841ec View commit details
    Browse the repository at this point in the history

  3. Fixed netfx build failure and PR feedback

    @gfoidl
    gfoidl committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    2cbc2a2 View commit details
    Browse the repository at this point in the history

  4. Fixed bug with null-ptr

    @gfoidl
    gfoidl committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    9419ff4 View commit details
    Browse the repository at this point in the history

  5. Reduce overhead

    @gfoidl
    gfoidl committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    3d03226 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Address feedback - fix 0x7F case, rename vectors to be self-documenting.

    @ahsonkhan
    ahsonkhan committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    2a64063 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'remotes/ahsonkhan/AddTextEncoderTests' … 

    …into ImproveEscapingCheck
    @gfoidl
    gfoidl committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    4c18251 View commit details
    Browse the repository at this point in the history

  3. Renamed mask vectors to be on par with Sse2Helper

    @gfoidl
    gfoidl committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    3b6659b View commit details
    Browse the repository at this point in the history

  4. Removed AggressiveInlining from FindFirstCharacterToEncode 

    These methods won't inline, and we don't want to inline them, as they're rather huge.
    @gfoidl
    gfoidl committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    2c68710 View commit details
    Browse the repository at this point in the history

  5. Reduced overhead

    @gfoidl
    gfoidl committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    e412e1e View commit details
    Browse the repository at this point in the history

  6. PR Feedback

    @gfoidl
    gfoidl committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    a0b9a69 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2019

  1. Better code for "not equal to zero" in Ssse3Helper 

    Cf. https://github.com/dotnet/corefx/pull/42073/files#r341709672
    @gfoidl
    gfoidl committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    cad3cb6 View commit details
    Browse the repository at this point in the history

  2. PR feedback 

    * #42073 (comment)
* #42073 (comment)
    @gfoidl
    gfoidl committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    1efba41 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ImproveEscapingCheck

    @gfoidl
    gfoidl committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    033ed82 View commit details
    Browse the repository at this point in the history