Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update top-level-templates.md #26338

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Update top-level-templates.md #26338

merged 4 commits into from
Oct 4, 2021

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Oct 1, 2021

Summary

  • Describe how to override the new template style

Fixes #26313

@adegeo adegeo requested a review from BillWagner October 1, 2021 15:59
@adegeo adegeo requested a review from tdykstra as a code owner October 1, 2021 15:59
@dotnet-bot dotnet-bot added this to the October 2021 milestone Oct 1, 2021
@adegeo
Copy link
Contributor Author

adegeo commented Oct 1, 2021

@BillWagner

tdykstra
tdykstra reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but we should also tell people how to do it in VS -- create .NET 5 project and change .csproj to target .net 6.

Also to elicit feedback, the new section could link to this issue and ask people to add their comments/votes.

BillWagner
BillWagner approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adegeo

After you add the comments from Tom, this is ready to :shipit:

docs/core/tutorials/top-level-templates.md Show resolved Hide resolved
@adegeo adegeo merged commit 0d5e4c5 into main Oct 4, 2021
@adegeo adegeo deleted the adegeo-26313-templates branch October 4, 2021 22:21
@Walluce
Copy link

Walluce commented Oct 6, 2021

I would prefer a setting in Visual Studio that lets me choose between old and new templates, by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Please document how to change default console template.
5 participants
@adegeo @Walluce @BillWagner @tdykstra @dotnet-bot