Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of workspaces layer by Formatting Analyzer during compilation #30472

Closed
sharwell opened this issue Oct 12, 2018 · 4 comments
Closed
Assignees
Labels
Area-IDE Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@sharwell
Copy link
Member

sharwell commented Oct 12, 2018

The code style layer should not embed workspaces assemblies in the NuGet package or load them during compilation scenarios.

This feels fairly hacky. We should be tracking the removal of this with a bug link.


In reply to: 222536172 [](ancestors = 222536172)

Originally posted by @jaredpar in https://github.com/dotnet/roslyn/timeline

@Neme12
Copy link
Contributor

Neme12 commented Nov 24, 2018

Why not? What's wrong with "code style" analyzers using features from workspaces?

@sharwell
Copy link
Member Author

@Neme12 The workspaces layer is not available during compilation. Without elaborate workarounds involving manual assembly resolvers (undesirable all around), analyzers referencing the workspace layer will only work inside the IDE and not from command line compilation scenarios.

@Neme12
Copy link
Contributor

Neme12 commented Nov 24, 2018

Sorry, I don't understand. If the code styles layer can be made available during compilation, why not workspaces?

@sharwell
Copy link
Member Author

The workspaces layer is large and has many dependencies not present in the compiler layer. It is omitted from compilation by design as a matter of principle (performance).

@sharwell sharwell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Nov 27, 2018
@sharwell sharwell modified the milestones: 16.0, 16.0.P2 Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

2 participants