Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SynthesizedReadOnlyListTypeSymbol.Create should check for MissingMetadataTypeSymbol for missing types #71297

Closed
cston opened this issue Dec 17, 2023 · 0 comments · Fixed by #71330
Closed

SynthesizedReadOnlyListTypeSymbol.Create should check for MissingMetadataTypeSymbol for missing types #71297

cston opened this issue Dec 17, 2023 · 0 comments · Fixed by #71330
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Milestone
17.9

Comments

@cston
Copy link
Member

cston commented Dec 17, 2023 •
edited
Loading

Originally posted by @alrz in #71110 (comment)

          > compilation.IsTypeMissing

This helper doesn't seem to be actually checking if the type is missing. It's rather "IsTypeMarkedAsMissing" and therefore is not suitable for non-test code. The proper way to do this I think is to check if the return value is of type MissingMetadataTypeSymbol. Is that correct?
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 17, 2023
@cston cston mentioned this issue Dec 17, 2023
Merged
@cston cston added this to the 17.9 milestone Dec 17, 2023
@cston cston changed the title SynthesizedReadOnlyListTypeSymbol.Create should check for MissingMetadataTypeSymbol rather than using Compilation.IsTypeMissing SynthesizedReadOnlyListTypeSymbol.Create should check for MissingMetadataTypeSymbol for missing types Dec 17, 2023
@alrz alrz mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9
Development

Successfully merging a pull request may close this issue.

SynthesizedReadOnlyListTypeSymbol.Create - Check for MissingMetadataTypeSymbol alrz/roslyn
1 participant
@cston