Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENC attributes are generated in different orders for different runtimes #73513

Open
jaredpar opened this issue May 16, 2024 · 0 comments
Open

Comments

@jaredpar
Copy link
Member

jaredpar commented May 16, 2024

In moving to the net9.0 runtime we discovered that a number of ENC tests have different custom attribute output ordering. This is likely from a non-deterministic source in the delta generator. It could also possibly be a change in runtime behavior but that seems unlikely.

  g.VerifyCustomAttributes(
  [
      new CustomAttributeRow(Handle(8, TableIndex.MethodDef), Handle(3, TableIndex.MethodDef)),
      new CustomAttributeRow(Handle(8, TableIndex.MethodDef), Handle(5, TableIndex.MethodDef)),
      new CustomAttributeRow(Handle(8, TableIndex.MethodDef), Handle(6, TableIndex.MethodDef)),
      new CustomAttributeRow(Handle(10, TableIndex.MethodDef), Handle(4, TableIndex.MethodDef)),
      new CustomAttributeRow(Handle(10, TableIndex.MethodDef), Handle(7, TableIndex.MethodDef)),
  ]);

Discovered in #73408

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 16, 2024
@genlu genlu added Interactive-EnC and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants