Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise arm64_unix_skip_list in runtest.py #42577

Closed
MichalStrehovsky opened this issue Sep 22, 2020 · 2 comments
Closed

Revise arm64_unix_skip_list in runtest.py #42577

MichalStrehovsky opened this issue Sep 22, 2020 · 2 comments
Labels
area-CrossGen/NGEN-coreclr disabled-test The test is disabled in source code against the issue
Milestone

Comments

@MichalStrehovsky
Copy link
Member

Found by accident when messing with the script in the runtimelab repo. We should probably revise the arm64_unix_skip_list.

This looks like an ARM64 bringup workaround from more than 2 year ago - I couldn't find associates issues. At this point it's probably just causing us to not have crossgen test coverage on ARM64 because I don't see what should be ARM64 specific on Microsoft.CodeAnalysis.VisualBasic.

arm64_unix_skip_list = [
".*Microsoft.CodeAnalysis.VisualBasic.*",
".*System.Net.NameResolution.*",
".*System.Net.Sockets.*",
".*System.Net.Primitives.*"
]

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 22, 2020
@am11
Copy link
Member

am11 commented Sep 22, 2020

Same case with other skip lists (skip_list, unix_skip_list) in this file. e.g. System.Runtime.WindowsRuntime.UI.Xaml project was deleted in #36715.

@jkotas jkotas added the disabled-test The test is disabled in source code against the issue label Sep 22, 2020
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Sep 23, 2020
@mangod9 mangod9 added this to the 6.0.0 milestone Sep 23, 2020
@mangod9
Copy link
Member

mangod9 commented Jul 26, 2021

since crossgen is no longer used this has part of the script has now been removed.

@mangod9 mangod9 closed this as completed Jul 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CrossGen/NGEN-coreclr disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

5 participants