Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Optimize stream reads #42651

Closed
scalablecory opened this issue Sep 23, 2020 · 4 comments
Closed

[QUIC] Optimize stream reads #42651

scalablecory opened this issue Sep 23, 2020 · 4 comments
Labels
Milestone

Comments

@scalablecory
Copy link
Contributor

The way we are implementing stream reads means we will often have more async/await overhead than is needed.

Instead of having an internal resettable task that we always await inside of ReadAsync, we should return a resettable task and have the MsQuic callback manage completing it. This will allow us to avoid an async state machine in ReadAsync().

@scalablecory scalablecory added this to the 6.0.0 milestone Sep 23, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 23, 2020
@ghost
Copy link

ghost commented Sep 23, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@scalablecory
Copy link
Contributor Author

Implementing this as part of #756

@ManickaP
Copy link
Member

@CarnaViire was this fixed with your PR which scavenged Cory's PR? Can you close this in case of a YES, please?

@CarnaViire
Copy link
Member

Yes, this was done in #55505

@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants