Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ! from Microsoft.Extensions.FileSystemGlobbing #58211

Closed
2 tasks done
Tracked by #64596
maxkoshevoi opened this issue Aug 26, 2021 · 2 comments · Fixed by #57398
Closed
2 tasks done
Tracked by #64596

Remove ! from Microsoft.Extensions.FileSystemGlobbing #58211

maxkoshevoi opened this issue Aug 26, 2021 · 2 comments · Fixed by #57398
Assignees
@maxkoshevoi
Labels
area-System.IO
Milestone
7.0.0

Comments

@maxkoshevoi
Copy link
Contributor

maxkoshevoi commented Aug 26, 2021 •
edited by jeffhandley
Loading

Description

This is a blanket issue for all ! operations that were added in #57398
They should be removed or reviewed.

Left to be fixed/reviewed:

  • FileSystemInfoBase.ParentDirectory should be able to return null, but none of the implementation do that (! were added to allow that though).
  • Implementations of DirectoryInfoBase differ in nullability for GetDirectory and GetFile
Class Can GetDirectory return null? Can GetFile return null?
DirectoryInfoBase No (according to <returns> doc) No (according to <returns> doc)
DirectoryInfoWrapper Yes No
InMemoryDirectoryInfo No Yes
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Aug 26, 2021
@ghost
Copy link

ghost commented Aug 26, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This is a blanket issue for all ! operations that were added in #57398
They should be removed or reviewed.

Left to be fixed/reviewed:

  • FileSystemInfoBase.ParentDirectory should be able to return null, but none of the implementation do that (! were added to allow that though).
  • Implementations of DirectoryInfoBase differ in nullability for GetDirectory and GetFile
Class Can GetDirectory return null? Can GetFile return null?
DirectoryInfoBase No (according to <returns> doc) No (according to <returns> doc)
DirectoryInfoWrapper Yes No
InMemoryDirectoryInfo No Yes
Author: maxkoshevoi
Assignees: -
Labels:

area-System.IO, untriaged
Milestone: -

@maxkoshevoi maxkoshevoi mentioned this issue Aug 26, 2021
Merged
@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Aug 27, 2021
@adamsitnik adamsitnik added this to the 7.0.0 milestone Aug 27, 2021
@jeffhandley jeffhandley mentioned this issue Feb 1, 2022
Closed
50 tasks
@jeffhandley jeffhandley linked a pull request Aug 9, 2022 that will close this issue
[Group 1] Enable nullable annotations for Microsoft.Extensions.FileSystemGlobbing #57398
Merged
@jeffhandley
Copy link
Member

Fixed in #57398

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maxkoshevoi maxkoshevoi

Labels
area-System.IO
Projects
None yet
Milestone
7.0.0
3 participants
@jeffhandley @adamsitnik @maxkoshevoi