Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify TarWriter.TarEntry(fileName, entryName) behavior if user owner and device numbers cannot be retrieved #81144

Closed
carlossanlop opened this issue Jan 25, 2023 · 2 comments

Comments

@carlossanlop
Copy link
Member

carlossanlop commented Jan 25, 2023

We fixed #81070 which was an issue in TarWriter.WriteEntry(string fileName, string entryName) where the method would crash if we attempted to add a file to an archive whose group owner name did not exist in the platform. This is the line that we fixed: TarWriter.Unix.cs#L85

Need to verify these two other locations:

The other two places in that same method that are ok to crash if they fail is when we do the lstat and when we create the FileStream for a regular file.

cc @jeffhandley

@carlossanlop
Copy link
Member Author

Item no. 1 has been verified by adding tests: #83126 and #83267

@ViktorHofer
Copy link
Member

According to the second point, if a crash occurs during retrieving the device major and minor then we can revisit issue.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants