Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] rationalize #includes in the native runtime #96081

Open
VSadov opened this issue Dec 16, 2023 · 1 comment
Open

[NativeAOT] rationalize #includes in the native runtime #96081

VSadov opened this issue Dec 16, 2023 · 1 comment

Comments

@VSadov
Copy link
Member

VSadov commented Dec 16, 2023

The native runtime has a complicated past. Base implementations had different plans about layering. Some things got stitched together from working pieces when productized. Although things work, it could be incrementally a nuisance to move forward.

  • Ideally #include would be about functionality a file wants to use directly. Indirect dependencies should be included implicitly.
  • Ideally there should be no sensitivity to the order of includes.

There are always exceptions from these rules, but there must be reasons.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 16, 2023
@ghost
Copy link

ghost commented Dec 16, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The native runtime had a complicated past. Some things are stitched together from working pieces and though things work, it could be incrementally difficult to move forward.

  • Ideally #include would be about functionality a file wants to use directly. Indirect dependencies should be included implicitly.
  • Ideally there should be no sensitivity to the order of includes.

There are always exceptions from these rules, but there must be reasons.

Author: VSadov
Assignees: -
Labels:

untriaged, area-NativeAOT-coreclr

Milestone: -

@MichalStrehovsky MichalStrehovsky added this to the Future milestone Feb 14, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants