Additional HTTP/3 and QUIC fixes #40675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix exception wrapping behavior. Make MsQuic async force async completion to avoid loading timing-sensitive MsQuic thread.
|
Tagging subscribers to this area: @dotnet/ncl |
jkotalik
approved these changes
Aug 11, 2020
geoffkizer
reviewed
Aug 11, 2020
| @@ -276,6 +276,10 @@ public async Task<HttpResponseMessage> SendAsync(CancellationToken cancellationT | |||
| catch (Exception ex) | |||
| { | |||
| _stream.AbortWrite((long)Http3ErrorCode.InternalError); | |||
| if (ex is HttpRequestException) | |||
There was a problem hiding this comment.
Code like this always makes me slightly queasy... feels like we are mixing exception usage across different layers of behavior. Not a huge deal, though.
geoffkizer
approved these changes
Aug 11, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Content-Length: 0 handling.
Fix exception wrapping behavior.
Make MsQuic force async completion to avoid loading timing-sensitive MsQuic thread.