-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
char.IsAscii xml doc comments #41753
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
cc @joperezr |
We didn't get a dump, and this was Ubuntu 18.04 which has been unwilling to give us dumps in the past. @HaoK do you now get dumps on Ubuntu 1804 in your test runs? I see I see https://github.com/dotnet/core-eng/issues/10616 was closed., I really don't like getting dumps.
|
I reopened it, on my prototype we get managed dmps but cores are sometimes missing |
Thanks @gfoidl |
Cf. #40936 (comment)
I based the text on
runtime/src/libraries/System.Private.CoreLib/src/System/Text/UnicodeUtility.cs
Line 120 in 2d463ee
/cc: @danmosemsft