Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DefaultContext test on wasm #42764

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix DefaultContext test on wasm #42764

merged 1 commit into from
Sep 29, 2020

Conversation

CoffeeFlux
Copy link
Contributor

Fixes #39202

Hopefully the test still works on Desktop with this change.

@CoffeeFlux CoffeeFlux added arch-wasm WebAssembly architecture area-System.Runtime labels Sep 26, 2020
@runfoapp runfoapp bot mentioned this pull request Sep 28, 2020
Closed
@CoffeeFlux CoffeeFlux merged commit 30bf648 into dotnet:master Sep 29, 2020
safern
safern reviewed Sep 29, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Runtime.Loader.DefaultContext test failing on Browser
3 participants
@CoffeeFlux @akoeplinger @safern