Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Move noilgen marshaling functions to a separate file #46046

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

CoffeeFlux
Copy link
Contributor

I need to be able to use a subset of these to replace the equivalent ilgen version, and previously they were spread out throughout marshal.c, meaning it created a really messy diff modifying tons of defines.

We've already created the (somewhat awkward) split with marshal-ilgen.c, so I don't see any downside to moving this stuff all out and under a single define.

also took the opportunity to get rid of trailing whitespace.

@ghost
Copy link

ghost commented Dec 14, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

I need to be able to use a subset of these to replace the equivalent ilgen version, and previously they were spread out throughout marshal.c, meaning it created a really messy diff modifying tons of defines.

We've already created the (somewhat awkward) split with marshal-ilgen.c, so I don't see any downside to moving this stuff all out and under a single define.

also took the opportunity to get rid of trailing whitespace.

Author: CoffeeFlux
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

@vargaz
Copy link
Contributor

vargaz commented Dec 15, 2020

Looks ok, but why is this needed ?

@CoffeeFlux
Copy link
Contributor Author

I want to be able to use a subset of them and it's much easier if they're separated out instead of having to modify each define individually. Alternatively I can group this in marshal.c, but I figured I'd move it out since it's just boilerplate bloating that file.

@marek-safar marek-safar merged commit 497c334 into dotnet:master Dec 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants