Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dtolnay/thiserror
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.34
Choose a base ref
...
head repository: dtolnay/thiserror
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.35
Choose a head ref
  • 20 commits
  • 8 files changed
  • 1 contributor

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    9e9afbf View commit details
    Browse the repository at this point in the history
  2. Merge pull request #186 from dtolnay/multipleprovide

    Add temporary ui test of 'multiple applicable items' error
    dtolnay committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2df0715 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd0bd70 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #187 from dtolnay/anyhowbacktrace

    Add test of getting backtrace from an anyhow source
    dtolnay committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2e4576c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4aa7a1c View commit details
    Browse the repository at this point in the history
  6. Merge pull request #188 from dtolnay/boxdynerrorbacktrace

    Add test involving backtrace from a Box<dyn Error>
    dtolnay committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c6b8fcf View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Configuration menu
    Copy the full SHA
    6957309 View commit details
    Browse the repository at this point in the history
  2. Ignore wildcard_imports pedantic clippy lint

        error: usage of wildcard import
          --> src/aserror.rs:45:9
           |
        45 |     use super::*;
           |         ^^^^^^^^ help: try: `super::{Error, UnwindSafe}`
           |
           = note: `-D clippy::wildcard-imports` implied by `-D clippy::pedantic`
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports
    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    85d812f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #189 from dtolnay/sealed

    Add Sealed supertrait to private AsDynError trait
    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    12acbc5 View commit details
    Browse the repository at this point in the history
  4. Sealed trait does not need its own module

    The aserror module is already private to thiserror, with AsDynError
    being re-exported in thiserror::private, so as long as Sealed is not
    also re-exported there, it remains inaccessible outside the crate.
    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    37442be View commit details
    Browse the repository at this point in the history
  5. Move multiple-provide test into test_backtrace

    Currently fails with:
    
        error[E0034]: multiple applicable items in scope
           --> tests/test_backtrace.rs:165:13
            |
        165 |             x: std::io::Error,
            |             ^ multiple `provide` found
            |
            = note: candidate #1 is defined in an impl of the trait `Provider` for the type `E`
            = note: candidate #2 is defined in an impl of the trait `std::error::Error` for the type `std::io::Error`
        help: disambiguate the associated function for candidate #1
            |
        165 |             Provider::provide(&x, Error): std::io::Error,
            |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        help: disambiguate the associated function for candidate #2
            |
        165 |             std::error::Error::provide(&x, Error): std::io::Error,
            |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    21198c9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3bcad59 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    293b127 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    460396e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    aaf8449 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    01e7c18 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #190 from dtolnay/provider

    Fix "Multiple applicable provide methods in scope"
    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2ca76ed View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1a90b77 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #191 from dtolnay/anyhowprovider

    Pull in Provider impl from anyhow 1.0.65
    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    9be0f41 View commit details
    Browse the repository at this point in the history
  14. Release 1.0.35

    dtolnay committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    10ffe03 View commit details
    Browse the repository at this point in the history
Loading