-
-
Notifications
You must be signed in to change notification settings - Fork 153
Comparing changes
Open a pull request
base repository: dtolnay/thiserror
base: 1.0.34
head repository: dtolnay/thiserror
compare: 1.0.35
- 20 commits
- 8 files changed
- 1 contributor
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9e9afbf - Browse repository at this point
Copy the full SHA 9e9afbfView commit details -
Merge pull request #186 from dtolnay/multipleprovide
Add temporary ui test of 'multiple applicable items' error
Configuration menu - View commit details
-
Copy full SHA for 2df0715 - Browse repository at this point
Copy the full SHA 2df0715View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd0bd70 - Browse repository at this point
Copy the full SHA bd0bd70View commit details -
Merge pull request #187 from dtolnay/anyhowbacktrace
Add test of getting backtrace from an anyhow source
Configuration menu - View commit details
-
Copy full SHA for 2e4576c - Browse repository at this point
Copy the full SHA 2e4576cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aa7a1c - Browse repository at this point
Copy the full SHA 4aa7a1cView commit details -
Merge pull request #188 from dtolnay/boxdynerrorbacktrace
Add test involving backtrace from a Box<dyn Error>
Configuration menu - View commit details
-
Copy full SHA for c6b8fcf - Browse repository at this point
Copy the full SHA c6b8fcfView commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6957309 - Browse repository at this point
Copy the full SHA 6957309View commit details -
Ignore wildcard_imports pedantic clippy lint
error: usage of wildcard import --> src/aserror.rs:45:9 | 45 | use super::*; | ^^^^^^^^ help: try: `super::{Error, UnwindSafe}` | = note: `-D clippy::wildcard-imports` implied by `-D clippy::pedantic` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports
Configuration menu - View commit details
-
Copy full SHA for 85d812f - Browse repository at this point
Copy the full SHA 85d812fView commit details -
Merge pull request #189 from dtolnay/sealed
Add Sealed supertrait to private AsDynError trait
Configuration menu - View commit details
-
Copy full SHA for 12acbc5 - Browse repository at this point
Copy the full SHA 12acbc5View commit details -
Sealed trait does not need its own module
The aserror module is already private to thiserror, with AsDynError being re-exported in thiserror::private, so as long as Sealed is not also re-exported there, it remains inaccessible outside the crate.
Configuration menu - View commit details
-
Copy full SHA for 37442be - Browse repository at this point
Copy the full SHA 37442beView commit details -
Move multiple-provide test into test_backtrace
Currently fails with: error[E0034]: multiple applicable items in scope --> tests/test_backtrace.rs:165:13 | 165 | x: std::io::Error, | ^ multiple `provide` found | = note: candidate #1 is defined in an impl of the trait `Provider` for the type `E` = note: candidate #2 is defined in an impl of the trait `std::error::Error` for the type `std::io::Error` help: disambiguate the associated function for candidate #1 | 165 | Provider::provide(&x, Error): std::io::Error, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: disambiguate the associated function for candidate #2 | 165 | std::error::Error::provide(&x, Error): std::io::Error, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Configuration menu - View commit details
-
Copy full SHA for 21198c9 - Browse repository at this point
Copy the full SHA 21198c9View commit details -
Revert "Directly call source.provide instead of going through dyn error"
This reverts commit f924c25.
Configuration menu - View commit details
-
Copy full SHA for 3bcad59 - Browse repository at this point
Copy the full SHA 3bcad59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 293b127 - Browse repository at this point
Copy the full SHA 293b127View commit details -
Configuration menu - View commit details
-
Copy full SHA for 460396e - Browse repository at this point
Copy the full SHA 460396eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf8449 - Browse repository at this point
Copy the full SHA aaf8449View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01e7c18 - Browse repository at this point
Copy the full SHA 01e7c18View commit details -
Merge pull request #190 from dtolnay/provider
Fix "Multiple applicable provide methods in scope"
Configuration menu - View commit details
-
Copy full SHA for 2ca76ed - Browse repository at this point
Copy the full SHA 2ca76edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a90b77 - Browse repository at this point
Copy the full SHA 1a90b77View commit details -
Merge pull request #191 from dtolnay/anyhowprovider
Pull in Provider impl from anyhow 1.0.65
Configuration menu - View commit details
-
Copy full SHA for 9be0f41 - Browse repository at this point
Copy the full SHA 9be0f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10ffe03 - Browse repository at this point
Copy the full SHA 10ffe03View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.0.34...1.0.35