From 434cab2539f35e00c4788cb48953b622950122dc Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Mon, 20 Nov 2023 01:07:38 -0800 Subject: [PATCH] chore(instrumentation-mysql2): drop unneed @types/mysql2 dep (#1812) Types are included in 'mysql2' now (as of some 2.x release). The github:types/mysql2 dependency is problematic for dependabot version updates. See: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1806#issuecomment-1816889209 Co-authored-by: Marc Pichler --- package-lock.json | 32 ------------------- .../package.json | 1 - 2 files changed, 33 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7da3b256d26..63901e92152 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10458,21 +10458,6 @@ "@types/node": "*" } }, - "node_modules/@types/mysql2": { - "version": "1.0.0", - "resolved": "git+ssh://git@github.com/types/mysql2.git#89378b2cb3974ea8cdd1d633b8f056e54e5d2384", - "dev": true, - "license": "ISC", - "dependencies": { - "@types/mysql": "types/mysql" - } - }, - "node_modules/@types/mysql2/node_modules/@types/mysql": { - "version": "2.0.0", - "resolved": "git+ssh://git@github.com/types/mysql.git#c26b1bc2bac17010081455e3127a90fb2eafcec9", - "dev": true, - "license": "ISC" - }, "node_modules/@types/node": { "version": "18.6.5", "resolved": "https://registry.npmjs.org/@types/node/-/node-18.6.5.tgz", @@ -36368,7 +36353,6 @@ "@opentelemetry/contrib-test-utils": "^0.34.3", "@opentelemetry/sdk-trace-base": "^1.8.0", "@types/mocha": "7.0.2", - "@types/mysql2": "github:types/mysql2", "@types/node": "18.6.5", "@types/semver": "7.5.3", "mocha": "7.2.0", @@ -45165,7 +45149,6 @@ "@opentelemetry/semantic-conventions": "^1.0.0", "@opentelemetry/sql-common": "^0.40.0", "@types/mocha": "7.0.2", - "@types/mysql2": "github:types/mysql2", "@types/node": "18.6.5", "@types/semver": "7.5.3", "mocha": "7.2.0", @@ -47778,21 +47761,6 @@ "@types/node": "*" } }, - "@types/mysql2": { - "version": "git+ssh://git@github.com/types/mysql2.git#89378b2cb3974ea8cdd1d633b8f056e54e5d2384", - "dev": true, - "from": "@types/mysql2@github:types/mysql2", - "requires": { - "@types/mysql": "types/mysql" - }, - "dependencies": { - "@types/mysql": { - "version": "git+ssh://git@github.com/types/mysql.git#c26b1bc2bac17010081455e3127a90fb2eafcec9", - "dev": true, - "from": "@types/mysql@types/mysql" - } - } - }, "@types/node": { "version": "18.6.5", "resolved": "https://registry.npmjs.org/@types/node/-/node-18.6.5.tgz", diff --git a/plugins/node/opentelemetry-instrumentation-mysql2/package.json b/plugins/node/opentelemetry-instrumentation-mysql2/package.json index c3140a7b25a..92fa96323af 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql2/package.json +++ b/plugins/node/opentelemetry-instrumentation-mysql2/package.json @@ -49,7 +49,6 @@ "@opentelemetry/contrib-test-utils": "^0.34.3", "@opentelemetry/sdk-trace-base": "^1.8.0", "@types/mocha": "7.0.2", - "@types/mysql2": "github:types/mysql2", "@types/node": "18.6.5", "@types/semver": "7.5.3", "mocha": "7.2.0",