Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would like to have a crack at getting this working with Gitea #6

Closed
winwisely99 opened this issue Jan 18, 2020 · 3 comments
Closed

Comments

@winwisely99
Copy link

I saw you had a go at it.

But with this relay it makes it easy to make any golang server support 2FA

@e3b0c442
Copy link
Owner

Hey, thanks for the offer!

That was actually the plan all along; my difficulties trying to transition to duo-labs/webauthn were the spark that lit the flame that got me to writing this library.

That said, I've already made the change locally but have not pushed yet; I wanted to get a couple more iterations on this library (especially re: attestation) and make sure the high-level API is stable before I integrate it with Gitea; in particular, I'm going to need to figure out the best way to provide for verifying the attestation trust path. I'm working on implementing the fido-u2f and packed attestation statement formats now, once I've finished that I think any necessary API changes will be in place and I'll feel comfortable pushing the Gitea code.

Closing this since it's more about Gitea, but I appreciate the offer!

@winwisely99
Copy link
Author

Can you raise an issue I can watch for in my notifications for when it's ready ?

@e3b0c442
Copy link
Owner

There is a draft PR open for the WebAuthn implementation: go-gitea/gitea#9451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants