Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing transparency on some elements when applying add_transparency #818

Open
3 tasks done
wroyca opened this issue Apr 17, 2024 · 1 comment
Open
3 tasks done
Labels

Comments

@wroyca
Copy link
Contributor

wroyca commented Apr 17, 2024

Contributing guidelines

Module(s)

Colors

Description

Hello o/

Using add_transparency({float = true}) with MiniColors will miss some elements, (e.g. MiniFilesTitles, MiniClueNextKeys, ...)

These are not "float" if we are pedantic with the definition, but they're part (as in, elements) of Mini floats so I believe they should follow suit

Neovim version

NVIM v0.10.0-dev+2931-g7fa24948a

Steps to reproduce

  1. nvim -nu minimal.lua
  2. lua MiniColors.interactive()
  3. add_transparency({float = true})
  4. lua MiniFiles.open() or lua MiniPick.builtin.grep_live() or others.

Expected behavior

Title, keys, and others that are on a transparent float should also have a transparent background to not look out of place.

Actual behavior

Screenshot from 2024-04-17 11-21-09
Screenshot from 2024-04-17 11-21-17
image

@wroyca wroyca added the bug Something isn't working label Apr 17, 2024
@echasnovski echasnovski added feature-request Feature request mini.colors and removed bug Something isn't working labels Apr 17, 2024
@echasnovski
Copy link
Owner

Thanks for the suggestion!

MiniColors.add_transparency() is mostly designed to work with built-in groups. Making exceptions for 'mini.nvim' is possible, but might be not very sustainable in the long run. I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants