Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requesting peer variant #11

Closed
sudoaugustin opened this issue Jun 20, 2022 · 4 comments · Fixed by #12
Closed

requesting peer variant #11

sudoaugustin opened this issue Jun 20, 2022 · 4 comments · Fixed by #12

Comments

@sudoaugustin
Copy link

I also have a custom plugin setup like yours.
But after I found your plugin, really wanna switch to yours and found peer variant missing.
You can find the peer variant of my plugin here.

@ecklf
Copy link
Owner

ecklf commented Jun 20, 2022

Sounds good and we can definitely add that. Just out of curiosity, is there a good use-case for the use of peer with radix primitives?

@sudoaugustin
Copy link
Author

This is my use case

I have two sibling dropdown components(Color Picker and Color Swatch) under a div. Instead of adding ring to (Color Picker's trigger and Color Swatch's trigger) when data-state=open, I wanna ring the div. We can't do that with focus:within. So What I need is to create a third sibling component and use peer variant. You can see my use-case sample here.

bla bla bla

@ecklf
Copy link
Owner

ecklf commented Jun 21, 2022

Should be working now. Let me know if you need anything else 🐐

@sudoaugustin
Copy link
Author

Thx u so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants