Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting behaving strangely in several Java devfiles #18448

Closed
6 of 22 tasks
ScrewTSW opened this issue Nov 24, 2020 · 5 comments
Closed
6 of 22 tasks

Syntax highlighting behaving strangely in several Java devfiles #18448

ScrewTSW opened this issue Nov 24, 2020 · 5 comments
Assignees
@sunix
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.27

Comments

@ScrewTSW
Copy link
Member

ScrewTSW commented Nov 24, 2020 •
edited
Loading

Describe the bug

Affected devfiles:

  • Java Gradle
  • Java Maven
  • Java with Spring Boot

After Java LS is initialized, the colors get messed up
Screenshot_20201124_163947
Screenshot_20201124_123751
Screenshot_20201124_123402

It is possible that the coulprit is Semantic highlighting
Screenshot_20201124_163602

Che version

  • latest
  • nightly
  • other: 7.22.0

Steps to reproduce

  • Start any of the above mentioned devfiles
  • Open a .java file
  • Wait for the LS to initialize, the colors will change

Expected behavior

  • Colors work correctly

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: OCP 4.5 on crw-qe.com (https://che-tdancs-che.apps.ocp45.crw-qe.com/), (che.prod-preview.openshift.io)

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
      chectl server:deploy -a operator -p openshift -n tdancs-che
    • provide an output of chectl version command
      chectl/7.22.0 linux-x64 node-v10.23.0
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other: OCP 4.5 on crw-qe
  • other: please specify

Eclipse Che Logs

https://pastebin.com/5zuav30Q

Additional context

N/A
@ScrewTSW ScrewTSW added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. area/plugins labels Nov 24, 2020
@sparkoo sparkoo added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 24, 2020
@Katka92
Copy link
Contributor

Katka92 commented Jan 13, 2021

Seen again in 7.24.1
captured (1)

@ericwill ericwill added this to the 7.26 milestone Jan 13, 2021
@ericwill ericwill mentioned this issue Jan 14, 2021
Closed
33 tasks
@ericwill ericwill mentioned this issue Feb 4, 2021
Closed
35 tasks
@ericwill ericwill modified the milestones: 7.26, 7.27 Feb 8, 2021
@ericwill ericwill assigned sunix and unassigned svor Feb 10, 2021
@sunix
Copy link
Contributor

sunix commented Feb 11, 2021

OK I could reproduce it, it is first ok but then once the java plugin is up...
Just after startup:
Selection_216
Then after few secs:
Selection_217

@sunix
Copy link
Contributor

sunix commented Feb 11, 2021 •
edited
Loading

Hello,
So after investigation, this is related to semantic highlighting. It is enabled by default. My guess is that CheTheia is failing to merge existing/builtin highlighting and the semantic one. I have to see what is the best option short term and long term.
I still have to test, but disabling semantic highlighting in the preferences for Java should work as a quickfix

@sunix sunix mentioned this issue Feb 12, 2021
Closed
9 tasks
@sunix
Copy link
Contributor

sunix commented Feb 12, 2021

Created an upstream issue eclipse-theia/theia#9058

@sunix sunix mentioned this issue Feb 12, 2021
Merged
9 tasks
@sunix
Copy link
Contributor

sunix commented Feb 13, 2021

Closing it, disabling semantic hightlighting fix the syntax highlighting: eclipse-che/che-theia#993

@sunix sunix closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunix sunix

Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.27
Development

No branches or pull requests
6 participants
@sunix @sparkoo @svor @ericwill @ScrewTSW @Katka92