Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return CodeActions[] instead of Commands[] if client supports code action literals #796

Closed
fbricon opened this issue Sep 18, 2018 · 2 comments

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 18, 2018

the server should check if the client supports codeActions, by checking if clientCapabilities.getTextDocument().getCodeAction().getCodeActionLiteralSupport() != null.
If codeActionLiteralSupport is supported, then return CodeActions. Else, return commands. See https://github.com/Microsoft/language-server-protocol/blob/gh-pages/specification.md#code-action-request-leftwards_arrow_with_hook (available since protocol 3.8.0).

We then might be able to phase out java.apply.workspaceEdit support in the future

@snjeza
Copy link
Contributor

snjeza commented Oct 9, 2018

A duplicate of #800

@fbricon
Copy link
Contributor Author

fbricon commented Nov 14, 2018

closing as duplicate of #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants