Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure WidgetManager creates same key for objects that are deep equal #11450

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Ensure WidgetManager creates same key for objects that are deep equal #11450

merged 1 commit into from
Jul 22, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Jul 21, 2022 •
edited
Loading

What it does

Fixes #11309 by using a library that produces stable stringifications for deep-equal objects.

How to test

  1. A test command is included in the first commit of this PR (to be dropped)

Label: Try opening the same file with different options!

  1. Running that command without the second commit should produce a log that says that it is false that the two widgets are equal.
  2. Running that command with the second commit of this PR should produce a log that says that it is true that the two widgets are equal.
  3. CI should pass.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the core issues related to the core of the application label Jul 21, 2022
@colin-grant-work colin-grant-work changed the title Bugfix/widget manager strinfication Ensure WidgetManager creates same key for objects that are deep equal Jul 21, 2022
paul-marechal
paul-marechal approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code+test LGTM and the 3PP check is green.

packages/core/src/browser/widget-manager.ts Outdated Show resolved Hide resolved
packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts Outdated Show resolved Hide resolved
@colin-grant-work colin-grant-work force-pushed the bugfix/widget-manager-strinfication branch from 19ac98f to cb9963f Compare July 21, 2022 20:22
@colin-grant-work colin-grant-work merged commit 896c343 into eclipse-theia:master Jul 22, 2022
@colin-grant-work colin-grant-work deleted the bugfix/widget-manager-strinfication branch July 22, 2022 14:31
@colin-grant-work colin-grant-work added this to the 1.28.0 milestone Jul 22, 2022
@kittaakos kittaakos mentioned this pull request Nov 11, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-marechal paul-marechal paul-marechal approved these changes

Assignees
No one assigned
Labels
core issues related to the core of the application
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.

[editor] Widget manager should compare widget keys with deep equals instead of string equal
2 participants
@colin-grant-work @paul-marechal