Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show "New File/Folder" on folders #11453

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 22, 2022

What it does

Closes #11452

Adds the explorerResourceIsFolder context so that these commands only appear on folders in the explorer.

How to test

  1. Open the file explorer
  2. Assert that the command isn't shown on files but continues to show on folders

Review checklist

Reminder for reviewers

@msujew msujew added the navigator issues related to the navigator/explorer label Jul 22, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍
The CI failures are expected with open-vsx being down.

@msujew msujew merged commit f980ff1 into master Jul 25, 2022
@msujew msujew deleted the msujew/add-context-to-new-file branch July 25, 2022 20:15
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show New File/Folder on files in explorer
2 participants