Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add tab related apis #11692

Closed
12 tasks
Tracked by #12010 ...
vince-fugnitto opened this issue Sep 22, 2022 · 16 comments · Fixed by #12109
Closed
12 tasks
Tracked by #12010 ...

vscode: add tab related apis #11692

vince-fugnitto opened this issue Sep 22, 2022 · 16 comments · Fixed by #12109
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Sep 22, 2022

Feature Description:

The goal is to add support for tab related VS Code APIs including:

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 22, 2022
@b4s36t4
Copy link

b4s36t4 commented Sep 22, 2022

@vince-fugnitto can you help me though implementing these things?

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto can you help me though implementing these things?

@b4s36t4 the change is pretty significant but if you want more details you can take a look at https://github.com/eclipse-theia/theia/blob/master/doc/Plugin-API.md. If you want to work on these APIs or any API please don't hesitate to ask specific questions.

@b4s36t4
Copy link

b4s36t4 commented Sep 22, 2022

https://github.com/eclipse-theia/theia/tree/master/packages/plugin-ext
I need to add the API thing in this package right @vince-fugnitto? is there any simpler way to communicate I'm new to these things and might need help of you more 😅

@vince-fugnitto
Copy link
Member Author

@b4s36t4 given you're new to the project I'd maybe suggest a simpler API to start, you can take a look at #11683 if you'd like or any API that looks interesting.

If you want to have discussions throughout your implementation you can create a discussion where I can respond without adding noise to the original issue.

@jbicker
Copy link
Contributor

jbicker commented Sep 23, 2022

@b4s36t4 and @vince-fugnitto, if you don't mind I would assign myself to this one.

@jbicker jbicker self-assigned this Sep 23, 2022
@JonasHelming
Copy link
Contributor

@jbicker Do you have an update about this? It would be super great if you find the time to contribute to this!

@jbicker
Copy link
Contributor

jbicker commented Dec 20, 2022

@JonasHelming Not yet. Sorry! I will continue soon.

@JonasHelming
Copy link
Contributor

Just a note: Maybe you want to stub the API first, so that it is already in place? We did the same for Notebook and the test API for now and it is rather low effort.

@jbicker
Copy link
Contributor

jbicker commented Dec 20, 2022

I'll have to check again, but I think I've already done that. I've been stuck with the implementation of the functionality behind the API. So, I can split that up.

@JonasHelming
Copy link
Contributor

That sounds great!

@jbicker
Copy link
Contributor

jbicker commented Dec 29, 2022

@JonasHelming #12031

@JonasHelming
Copy link
Contributor

@jbicker Is there a chance the real impl makes it into the Jan release?

@jbicker
Copy link
Contributor

jbicker commented Jan 16, 2023

@JonasHelming I think there is a chance. But I wouldn't promise.

@jbicker
Copy link
Contributor

jbicker commented Jan 16, 2023

Btw. what is the release date?

@JonasHelming
Copy link
Contributor

Jan 26th

@jbicker
Copy link
Contributor

jbicker commented Jan 19, 2023

So far I implemented the functions to close tabs and tabgroups. See d5c9423
Since I do not have time for further implementation this month @jonah-iden will take over that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants