Support DocumentDropEditProvider (#12025)
#12125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
(still need to access filesystem in adapter though) Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
changed the title
DocumentDropEditProvider (#12025)
msujew
reviewed
Feb 9, 2023
packages/plugin-ext/src/main/browser/data-transfer/data-transfer-type-converters.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
|
@jonah-iden @msujew : What is the state of this PR? |
|
I have applied all suggested review changes. So if there aren't any other comments this could be merged |
msujew
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
I'm happy with the changes, looks good to me 👍
- The sample extension works as expected with the new API
- The inversion of file system <-> language services plugin dependencies works as well
- The comparator status report marks the API as fully supported
I'll merge this PR in the coming days, if there are no objections.
1 task
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
resolves #12025
this implements the vscode extension api for
DocumentDropEditDocumentDropEditProviderlanguagenamespacealso implments DTOs including converters and ability to resolve the file Data for those for #11776.
How to test
here is a small test extension:
documentdropedit-test-0.0.1.zip
or you can build it here:
https://github.com/jonah-iden/documentdropedit-test
Review checklist
Reminder for reviewers