Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing menus in CommentSample #12452

Open
rschnekenbu opened this issue Apr 24, 2023 · 0 comments
Open

Missing menus in CommentSample #12452

rschnekenbu opened this issue Apr 24, 2023 · 0 comments
Labels
comments issues related to comments api and functionality vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

Some buttons generated by commands are missing in the comment sample since Theia release 1.28. This can be observed when the menu refactoring #11290 was applied. Before that refactoring, for example on theia 1.27, the buttons were displayed without issues and working.

This was discovered while working on PR #12007 and the issue #12231.
From what I could observe:

  • Before refactoring, the buttons could be seen on the comment sample editor. The process to get the dialog is documented in this CommentThread state PR

theia-1 27-comment

  • After refactoring, e.g. on Theia 1.28+, almost no buttons can be seen using same extension.

theia-master-comment

@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility comments issues related to comments api and functionality labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comments issues related to comments api and functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants