Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks can't be run through the shell #2960

Closed
simark opened this issue Sep 24, 2018 · 3 comments
Closed

Tasks can't be run through the shell #2960

simark opened this issue Sep 24, 2018 · 3 comments
Labels
tasks issues related to the task system

Comments

@simark
Copy link
Contributor

simark commented Sep 24, 2018

If you try the following task in vscode:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "A task",
            "type": "shell",
            "command": "echo {Hello,world!}"
        }
    ]
}

it outputs Hello world!. {Hello,world!} becoming Hello world! is the result of the command being run through bash (or another compatible shell).

With Theia, we don't run the task through the user's shell, which results in the following error:

Error launching task 'A task': Error: Request run failed with message: Command not found: echo {Hello,world!}

Since we aim for vscode compatibility for tasks (and because shells are nice tools), we should support this.

@simark simark added the tasks issues related to the task system label Sep 24, 2018
@simark
Copy link
Contributor Author

simark commented Sep 24, 2018

From what I understand reading this, if the type of the task is "shell", the command should be the full command line, including arguments, to be interpreted by the shell. The "args" property is ignored. If type is "process", "command" should be only the executable name and the "args" property is used. But in both cases, a terminal showing the output is opened by default.

@elaihau
Copy link
Contributor

elaihau commented Jul 22, 2019

@marechal-p could this one be closed?

@paul-marechal
Copy link
Member

More details: 2b95010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

No branches or pull requests

3 participants