Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high contrast theming #6743

Closed
akosyakov opened this issue Dec 12, 2019 · 8 comments · Fixed by #11280
Closed

high contrast theming #6743

akosyakov opened this issue Dec 12, 2019 · 8 comments · Fixed by #11280
Labels
accessibility issues related to accessbilitiy help wanted issues meant to be picked up, require help theming issues related to theming vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

Review how VS Code applies high contrast colors https://code.visualstudio.com/api/references/theme-color#contrast-colors and apply them similarly in Theia.

We leave it out from the initial theming.

@akosyakov akosyakov added theming issues related to theming vscode issues related to VSCode compatibility accessibility issues related to accessbilitiy labels Dec 12, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jan 3, 2020
@kittaakos
Copy link
Contributor

Some issues are also listed here: #7353

  • selection in the Explorer,
  • border of the buttons in the dialogs,
  • tbd

@kittaakos
Copy link
Contributor

The context menu, in the browser example, is also broken:

Screen Shot 2020-03-18 at 09 08 05

@kittaakos
Copy link
Contributor

[nitpick]: I think the border of the left side-bar is not aligned with the main menu bar:
Screen Shot 2020-03-18 at 09 13 25

@kaiyue0329
Copy link
Contributor

In the Problems View, there is no border around the selected node.

In VS code,
image

In Theia,
image
(Arrow pointing to the selected node)

@kittaakos kittaakos self-assigned this Apr 2, 2020
@kittaakos
Copy link
Contributor

Editor and Explorer decorators always white with the HC theme. I would expect red and yellowish colors.
Screen Shot 2020-04-02 at 16 13 43

@kittaakos
Copy link
Contributor

Also: #7489

@kittaakos
Copy link
Contributor

Support for hover. VS Code:
screencast 2020-04-02 17-21-32

TODO: Revisit whether we want to support it for dialog buttons or not. VS Code does not have any dialogs but they do not support it in the Explorer:

screencast 2020-04-02 17-47-00

@kittaakos
Copy link
Contributor

Difference between the editor error markers:
VS Code
Screen Shot 2020-04-02 at 18 15 48

Theia:
Screen Shot 2020-04-02 at 18 15 57

Maybe it is a TS issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility issues related to accessbilitiy help wanted issues meant to be picked up, require help theming issues related to theming vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants