Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'last commit' and amend support so still there when using git vscode built-in #7152

Open
westbury opened this issue Feb 14, 2020 · 3 comments
Labels
git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager

Comments

@westbury
Copy link
Contributor

Description

We should move the git amend support into git-extra package and ensure it works with both @theia/git and the built-in. The SCM-independent part of the amend support should be moved to scm-extra, with the SCM view having support for contributions to the bottom of the view.

This work follows on from #6381

Reproduction Steps

Remove @theia/git from the build and drop in the Git built-in plugin. You will see that the 'last commit' section at the bottom of the SCM view has disappeared. The 'last commit' section should be there the same regardless of whether @theia/git or the plugin is being used.

@westbury westbury added git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager labels Feb 14, 2020
@westbury
Copy link
Contributor Author

westbury commented Apr 7, 2020

I plan on working on this after #7505 . That PR converts the parts of the Source Control view to widgets, so then this issue can be solved by allowing downstream packages to contribute widgets to the bottom of the Source Control view.

The uncertainty I have, however, is that we will have both the Git built-in and Theia's Dugite code both accessing the same repository. I have not yet tested to see if this creates issues. The built-in does not expose what we need to do the 'amend' suport.

@vince-fugnitto
Copy link
Member

@westbury any news on the issue? I believe it is the last remaining blocker for #7482.

@westbury
Copy link
Contributor Author

@vince-fugnitto I've had the PR opened and ready to go for a while. I too was wondering about the state of this, and whether there is still interest in moving to the built-in. We still have concerns about using the built-in, which generally come down to the fact that we can't configure it. Maintaining our own fork of the Git built-in is something we would really like to avoid.

In any case I need to rebase the PR so I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants