Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferences: improve category headers #7745

Closed
vince-fugnitto opened this issue May 5, 2020 · 2 comments
Closed

preferences: improve category headers #7745

vince-fugnitto opened this issue May 5, 2020 · 2 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

Following #7105, we should improve category headers present in the view.
At the moment, subcategories are styled similarly to categories which makes their appearance confusing. For instance, take the preference markdown.links.openLocation for example:

Theia:

Screen Shot 2020-05-05 at 9 37 57 AM

VS Code:

Screen Shot 2020-05-05 at 9 37 48 AM

In Theia, it looks like there are two categories (Markdown and Links), and it gives the impression that Markdown is empty.

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences labels May 5, 2020
@liorfr
Copy link

liorfr commented Sep 15, 2020

Also,

Theia:
The category in the leaf starts from the second category word when the category has more than one word
image

VS Code:
VS Code Has semicolon after subcategories
image

@vince-fugnitto
Copy link
Member Author

I believe this can be closed thanks to #9439.

when no search is present:

Screen Shot 2021-07-15 at 4 13 07 PM

when a search is present ('markdown')

Screen Shot 2021-07-15 at 4 13 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

2 participants