Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tasks start and exit with code 0 notifications #8327

Closed
amiramw opened this issue Aug 6, 2020 · 2 comments · Fixed by #8331
Closed

Remove tasks start and exit with code 0 notifications #8327

amiramw opened this issue Aug 6, 2020 · 2 comments · Fixed by #8331
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help tasks issues related to the task system

Comments

@amiramw
Copy link
Member

amiramw commented Aug 6, 2020

Feature Description:

Currently when running a task there are user notifactions for:

  • Task 'X' has been started.
  • Task 'X' has exited with code 0.

Can we remove those messages? VS Code doesn't have those and they seems too much information for the user.
@vince-fugnitto vince-fugnitto added proposal feature proposals (potential future features) tasks issues related to the task system labels Aug 7, 2020
@vince-fugnitto
Copy link
Member

I'd be fine with the notifications removed, the notifications were present before we added the message when tasks were started and terminated directly in the terminal: ef0eba6.

@amiramw amiramw mentioned this issue Aug 9, 2020
Merged
1 task
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help and removed proposal feature proposals (potential future features) labels Aug 10, 2020
@akosyakov
Copy link
Member

I think aligning with VS code here is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tasks start and exit with code 0 notifications eclipse-theia/theia
3 participants
@akosyakov @amiramw @vince-fugnitto