Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-editor: changeset unnecessarily pulls '@theia/editor-preview' #9300

Closed
vince-fugnitto opened this issue Apr 6, 2021 · 0 comments · Fixed by #9302
Closed

custom-editor: changeset unnecessarily pulls '@theia/editor-preview' #9300

vince-fugnitto opened this issue Apr 6, 2021 · 0 comments · Fixed by #9302
Labels
custom-editor issues related to custom-editor functionality plug-in system issues related to the plug-in system quality issues related to code and application quality

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The change #8910 adds an unnecessary coupling to @theia/editor-preview, and means that downstream applications cannot easily opt-out of using @theia/editor-preview as part of their application. This is considered a breaking change.

I think in this particular instance the coupling can be avoided:

import { PreviewEditorOpenerOptions } from '@theia/editor-preview/lib/browser';

canHandle(uri: URI, options?: PreviewEditorOpenerOptions): number {

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality plug-in system issues related to the plug-in system custom-editor issues related to custom-editor functionality labels Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-editor issues related to custom-editor functionality plug-in system issues related to the plug-in system quality issues related to code and application quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant