electron: remove disallowReloadKeybinding

[vince-fugnitto]

Feature Description:

The application configuration option disallowReloadKeybinding is no longer used, and can be deprecated/removed:

theia/dev-packages/application-package/src/application-props.ts

Lines 40 to 47 in 08722fa

	/**
	* If set to `true`, reloading the current browser window won't be possible with the `Ctrl/Cmd + R` keybinding.
	*
	* Has no effect if not in an electron environment.
	*
	* Defaults to `false`.
	*/
	readonly disallowReloadKeybinding?: boolean;

It is currently only used in a test, where i can be safely removed:

theia/packages/core/src/browser/frontend-application-config-provider.spec.ts

Lines 33 to 48 in 08722fa

	it('should use defaults when calling `set`', function (): void {
	FrontendApplicationConfigProvider.set({
	applicationName: DEFAULT.applicationName + ' Something Else',
	electron: {
	disallowReloadKeybinding: !DEFAULT.electron.disallowReloadKeybinding
	}
	});
	const config = FrontendApplicationConfigProvider.get();
	// custom values
	expect(config.applicationName).not.equal(DEFAULT.applicationName);
	expect(config.electron.disallowReloadKeybinding).not.equal(DEFAULT.electron.disallowReloadKeybinding);
	// defaults
	expect(config.defaultIconTheme).equal(DEFAULT.defaultIconTheme);
	expect(config.defaultTheme).equal(DEFAULT.defaultTheme);
	expect(config.electron.windowOptions).deep.equal(DEFAULT.electron.windowOptions);
	});

Related Info:

• Remove global shortcuts from Electron, use WindowService for reload #10704 (comment)