Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel support for operations #236

Open
angelozerr opened this issue Sep 3, 2022 · 1 comment
Open

Cancel support for operations #236

angelozerr opened this issue Sep 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@angelozerr
Copy link
Contributor

When an operation is processed several times (ex : user type several characters, some operations are done like codeLens). It should be nice to cancel:

  • the codeLens request : if language server manages correctly the cancel support, it will stop the compute of codelens and will throws a CancellableException.
  • the process of the codeLens request result : we should stop to update CodeMing in this case.

For hover when user hove something and language server takes some times and user move the mouse, in this case the hover request must be canceled in order to language server stops the process.

IMHO I think it will improve the performance when some process could take time on language server and language server will be more responsive.

@rubenporras
Copy link
Contributor

Also if a context assist request is send, it should be cancelled when the cursor is moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants