Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a way to specify the verify= argument to httpx.Client #87

Closed
fisherdog3 opened this issue May 7, 2024 · 5 comments
Closed

Comments

@fisherdog3
Copy link

Description

If a non-standard certificate is needed, eg on a corporate network, volare will not work. Reports not connected to the internet with ls-remote. Httpx does not seem to care about the system SSL certs in the usual search dirs but I could be mistaken. Other software which would be affected, conda and pip, do not have any issue connecting as I have installed the required cert. I was able to workaround by rebuilding with the verify= argument in the Client constructor.

Expected Behavior

Should perform an ls-remote

Relevant command

volare ls-remote

Relevant log output

You don't appear to be connected to the Internet. ls-remote cannot be used.
@fisherdog3
Copy link
Author

Supporting my claim that HTTPX is not using my certs:
encode/httpx#302

@donn
Copy link
Member

donn commented May 23, 2024

That would've been a nightmare to implement so what I did was: You can now pip3 install volare[truststore] which will use your computer's trust store.

@donn
Copy link
Member

donn commented May 23, 2024

Can you confirm this works for you?

@fisherdog3
Copy link
Author

This is working for me and I can ls-remote right after install.

@donn
Copy link
Member

donn commented May 30, 2024

Glad to hear! Feel free to open another issue if you run into anything else. :)

@donn donn closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants