Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule pods on a nodegroup on which no concurrent actions are executed #7834

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Jun 13, 2024

Description

Fixes #7792

CRUD integration test creates a bunch of nodegroups, on which, some of the specs, then execute different operations e.g. scale, delete, etc. Other parallel specs apply daemonsets, deployments, etc. Depending on timing, one spec might delete and/or drain a node onto which pods were scheduled by another spec, right when the namespace in which the pods are running is being terminated.

To fix ☝🏻, this PR ensures that all pods are scheduled on a separate nodegroup, onto which no other concurrent action is being executed.

Manual testing

https://github.com/eksctl-io/eksctl-ci/actions/runs/9510689795/job/26218234718

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC marked this pull request as ready for review June 14, 2024 07:42
@TiberiuGC TiberiuGC requested a review from cPu1 June 14, 2024 07:42
@TiberiuGC TiberiuGC merged commit 4b62d1a into main Jun 14, 2024
10 checks passed
@TiberiuGC TiberiuGC deleted the bugfix/crud-flake-schedule-pods-on-stable-ng branch June 14, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD integration test intermittently fails
2 participants