Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Investigate decoration of span.destination.service.* attributes for gRPC services #304

Open
rogercoll opened this issue Jul 1, 2024 · 0 comments

Comments

@rogercoll
Copy link

This issue was detected when deploying the OpenTelemetry demo and using the Elastic's OpenTelemetry endpoint. In case the service is doing internal calls using gRPC (e.g. the checkout service), all the span.destination.service.* attributes are set to the value :0:

image

The issue is solved if the corresponding services include the peer.service attribute in their spans, but I reckon it would be more informative for the user to provide a different value other than :0 if peer.service is not defined. For example, unknown or just not providing the default port value?

For HTTP services, the span.destination.service.* are populated accordingly, my guess is because of the library extracting the destination values from the HTTP URL instead of the peer attribute: https://github.com/elastic/apm-data/blob/main/input/otlp/traces.go#L1006

Ongoing work to add peer.service in the OpenTelemetry demo: open-telemetry/opentelemetry-demo#1635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant