Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using asciidoctor compat-mode #728

Open
nik9000 opened this issue Mar 15, 2019 · 2 comments
Open

Stop using asciidoctor compat-mode #728

nik9000 opened this issue Mar 15, 2019 · 2 comments
Labels
asciidoc Asciidoc and our Asciidoctor extensions defer

Comments

@nik9000
Copy link
Member

nik9000 commented Mar 15, 2019

Right now we use Asciidoctor's compat-mode feature to ease our transition from AsciiDoc. It isn't complete compatibility, but it sure helps. We should transition away from using it somehow. Eventually.

@gtback gtback added the asciidoc Asciidoc and our Asciidoctor extensions label May 14, 2020
@hackery
Copy link

hackery commented Aug 7, 2020

In particular, there are places in the documentation where contributors have used "new" syntax, which renders incorrectly with compat-mode on.

e.g. Logstash Field References Deep Dive shows references like +[[deep][nesting]][field]+ but the enclosing + signs are spurious (and suggest some field reference syntax that's not described and doesn't exist).

image

The source in field-reference.asciidoc renders correctly when viewed on Github (which isn't using compat-mode) but the raw version shows where the "new" syntax is being used: `+ ... +`

@gtback
Copy link
Member

gtback commented Aug 11, 2020

Thanks, @hackery. That's a good datapoint.

@gtback gtback added the defer label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asciidoc Asciidoc and our Asciidoctor extensions defer
Projects
None yet
Development

No branches or pull requests

3 participants