Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexShard#failShard should throw an AlreadyClosedException #17366

Closed
jasontedor opened this issue Mar 28, 2016 · 2 comments
Closed

IndexShard#failShard should throw an AlreadyClosedException #17366

jasontedor opened this issue Mar 28, 2016 · 2 comments
Labels
:Core/Infra/Core Core issues without another label >enhancement help wanted adoptme v5.4.4

Comments

@jasontedor
Copy link
Member

Today when failing a shard via IndexShard#failShard, we silently swallow cases where the engine is already closed. Instead, we should throw an AlreadyClosedException.
@jasontedor jasontedor added >enhancement :Core/Infra/Core Core issues without another label labels Mar 28, 2016
@jasontedor jasontedor mentioned this issue Mar 28, 2016
Merged
@s1monw
Copy link
Contributor

s1monw commented Mar 28, 2016

++

@clintongormley
Copy link

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >enhancement help wanted adoptme v5.4.4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @s1monw @jasontedor