Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Geo aggregations in X-Pack #53600

Closed
nknize opened this issue Mar 16, 2020 · 3 comments
Closed

Override Geo aggregations in X-Pack #53600

nknize opened this issue Mar 16, 2020 · 3 comments
Labels
:Analytics/Aggregations Aggregations :Analytics/Geo Indexing, search aggregations of geo points and shapes >feature Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nknize
Copy link
Contributor

nknize commented Mar 16, 2020

This is the second (of two) critical issues in preparation for geo_shape support for geo aggregations. To prevent a dependency on Value Source Refactor from further delaying the release of geo_shape doc values and aggregation support, a temporary solution of registering geo aggregations in the X-Pack spatial plugin is suggested by using the module framework. Much like the approach to overriding doc_values parameter, the SearchModule class will register geo_ aggregation implementations through a thin OSS geo module that provides the base classes necessary to implement Basic+ functionality in the X-Pack spatial module (when the appropriate license level is available). In this manner, the OSS implementations will only be registered absent a Basic+ license.

This approach allows the geo_shape doc value feature to move forward independent of any additional work to the aggregation framework paving the way to potentially release the feature earlier than anticipated.

@nknize nknize added >feature :Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/Aggregations Aggregations team-discuss labels Mar 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
@iverase
Copy link
Contributor

iverase commented Jun 12, 2020

@nknize Can this be closed?

@iverase
Copy link
Contributor

iverase commented Jun 18, 2020

I am closing this as it has been done and Elasticsearch 7.8 supports aggregations over geo_shape.

@iverase iverase closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations :Analytics/Geo Indexing, search aggregations of geo points and shapes >feature Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

4 participants