From 06ef3389dca268a73141fe482cb72dbc60c6f852 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Mon, 22 Aug 2022 12:32:08 -0700 Subject: [PATCH] Remove EuiDescritpionList IE comments - Many consumers are overriding `width` instead of `flex-basis` at this point for the component, so changing it to flex-basis would cause unnecessary churn - `width` is also still valid and intuitive to use instead over flex-basis --- .../description_list/description_list_description.styles.ts | 2 +- .../description_list/description_list_title.styles.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/description_list/description_list_description.styles.ts b/src/components/description_list/description_list_description.styles.ts index 46d2aa013c0..1eafff3ba5c 100644 --- a/src/components/description_list/description_list_description.styles.ts +++ b/src/components/description_list/description_list_description.styles.ts @@ -22,7 +22,7 @@ export const euiDescriptionListDescriptionStyles = ( const { euiTheme } = euiThemeContext; const columnDisplay = ` - ${logicalCSS('width', '50%')} // Flex-basis doesn't work in IE with padding + ${logicalCSS('width', '50%')} ${logicalCSS('padding-left', euiTheme.size.s)} &:not(:first-of-type) { ${logicalCSS('margin-top', euiTheme.size.base)} diff --git a/src/components/description_list/description_list_title.styles.ts b/src/components/description_list/description_list_title.styles.ts index b6c186b8e6f..fe6b78733a6 100644 --- a/src/components/description_list/description_list_title.styles.ts +++ b/src/components/description_list/description_list_title.styles.ts @@ -21,7 +21,7 @@ export const euiDescriptionListTitleStyles = (euiThemeContext: UseEuiTheme) => { const { euiTheme, colorMode } = euiThemeContext; const columnDisplay = ` - ${logicalCSS('width', '50%')} // Flex-basis doesn't work in IE with padding + ${logicalCSS('width', '50%')} ${logicalCSS('padding-right', euiTheme.size.s)} `; return {