From 256c55cbb956bde4a844727e3a3b51f852c359f0 Mon Sep 17 00:00:00 2001
From: Lene Gadewoll <lene.gadewoll@elastic.co>
Date: Wed, 10 Apr 2024 13:47:01 +0200
Subject: [PATCH] docs(storybook): PR feedback

- removes skeleton in favor of string to ensure valid HTML

+ adds parent= on bottom bar to ensure last position on DOM updates
---
 .../page_template/page_template.stories.tsx           | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/components/page_template/page_template.stories.tsx b/src/components/page_template/page_template.stories.tsx
index 195d3667276..f21c8a2db88 100644
--- a/src/components/page_template/page_template.stories.tsx
+++ b/src/components/page_template/page_template.stories.tsx
@@ -25,12 +25,7 @@ const headerContent = (
     iconType="logoElastic"
     pageTitle="Page title"
     rightSideItems={[<EuiButton>Button</EuiButton>]}
-    description={
-      <EuiSkeletonText
-        lines={1}
-        contentAriaLabel="Page header example description"
-      />
-    }
+    description="Page header example description"
     tabs={[{ label: 'Tab 1', isSelected: true }, { label: 'Tab 2' }]}
   />
 );
@@ -58,7 +53,9 @@ const sidebarContent = (
   </EuiPageTemplate.Sidebar>
 );
 const bottomBarContent = (
-  <EuiPageTemplate.BottomBar paddingSize="s">
+  // adding parent="" here to prevent using a portal and to ensure the
+  // last position on changes when the parent does not change
+  <EuiPageTemplate.BottomBar paddingSize="s" parent="">
     <EuiSkeletonText lines={1} contentAriaLabel="Bottom bar example text" />
   </EuiPageTemplate.BottomBar>
 );