Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuggest] Status changes width of text field #2528

Closed
i-a-n opened this issue Nov 14, 2019 · 2 comments
Closed

[EuiSuggest] Status changes width of text field #2528

i-a-n opened this issue Nov 14, 2019 · 2 comments
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@i-a-n
Copy link
Contributor

i-a-n commented Nov 14, 2019

Hi team. I noticed that when changing the status on an <EuiSuggest> element, typically from "unchanged" to "loading", that the width can change by a fair amount, up to 20 pixels. This causes a serious amount of jank on layouts that are dynamic and not full-width.

Here's a pared-down example where a two-column flexbox layout is disrupted by toggling the loading state on/off. Just type slowly in the text field to toggle the status: https://codesandbox.io/s/optimistic-shadow-rlvq1

This isn't a blocker or anything for me, but I thought I'd bring it up for discussion and further tracking if it's something we want to fix.

@andreadelrio
Copy link
Contributor

@i-a-n thanks for reporting this. I'm trying to pin point the problem. So far, I've reproduced your example with EuiFieldText instead (which EuiSuggest uses behind the scenes) and the same jumping happens. So the problem is probably happening at the EuiFieldText level.
a_ezgif com-video-to-gif (1)
Also, not sure if this is 100% relevant but when building the 2-column layout using EuiFlexGroup and EuiFlexItem the jumping does not ocurr.
a_ezgif com-video-to-gif_2

@cchaos cchaos added assign:anyone ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Mar 18, 2020
@cchaos cchaos added the bug label Sep 20, 2020
@thompsongl
Copy link
Contributor

Fixed in #5157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

4 participants