Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Allow sticky columns #2839

Open
Tracked by #182611
pickypg opened this issue Feb 10, 2020 · 18 comments
Open
Tracked by #182611

[EuiDataGrid] Allow sticky columns #2839

pickypg opened this issue Feb 10, 2020 · 18 comments

Comments

@pickypg
Copy link
Member

pickypg commented Feb 10, 2020

I got some feedback on a particularly wide usage of data grid where some people would like to lock some columns so that when they are forced to horizontally scroll, they get the column(s) that they're most interested in stuck on the screen.

I assume that the same applies to a sticky row in the same way that spreadsheets support both directions.

@chandlerprall
Copy link
Contributor

👍Sticky columns & rows is on the feature list, but hasn't yet been roadmapped / planned.

@kertal
Copy link
Member

kertal commented May 26, 2020

@chandlerprall think we need also a a sticky column for Discover. in case there's a time column, it's always first and shouldn't be moveable. the horizontally scrolling feature would be nice, but not necessary for the initial use case

@chandlerprall
Copy link
Contributor

For completeness, @kertal and I talked on Slack about this being a blocker for Discover. The hard requirements will be given some more thought first. While sticky columns is on the list, getting development time against it is the harder part right now so the smallest set of requirements will be much faster to implement. This can provide a good opportunity to start developing an API without building out the entire interaction - e.g. programmatically define a sticky column but don't give the user any menus for managing, etc.

@kertal
Copy link
Member

kertal commented Jun 10, 2020

FYI @chandlerprall, found a solution for Discover, no more potential blocker it is:

elastic/kibana#67259 (comment)

@cchaos cchaos changed the title [Data Grid] Allow sticky columns [EuiDataGrid] Allow sticky columns Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@pickypg
Copy link
Member Author

pickypg commented Mar 20, 2021

Still needed.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@kertal
Copy link
Member

kertal commented Sep 27, 2021

Still valid, I'd say

@joel-orcutt
Copy link

This seems like a highly valuable feature for larger datagrid displays

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@snide
Copy link
Contributor

snide commented Mar 28, 2022

Added skip-stale-check on this one. We'll want this one.

@snide snide removed the stale-issue label Mar 28, 2022
@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@WesKetch
Copy link

Hey! Are you all still interested in adding this feature? Would you be open to a PR contribution? This would be a great addition to the grid and our team would be up for trying to add it.

@kertal
Copy link
Member

kertal commented May 23, 2023

Personally, I'd say yes. I'd say a PR is always welcome, right @cee-chen. Only keep in mind, this is no small change

@cee-chen
Copy link
Member

cee-chen commented May 23, 2023

Yes, for sticky columns integrated directly into our virtualized grid body, there isn't any official support in our react-window dependency (although it looks like there's some semi-hacky workarounds in the comments).

A cleaner approach might to be to write a custom renderer for the renderCustomGridBody API, which would ditch the virtualization hurdle entirely.

Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@davismcphee
Copy link
Contributor

Just bumping this one to keep it open 🙂 Another use case for this is the new document comparison mode we're adding in Discover, where making the "Field" column sticky would be valuable for users comparing multiple documents that result in horizontal scrolling:
compare

Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants