Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiColorStops] Beginning from empty should look more empty #2876

Closed
cchaos opened this issue Feb 19, 2020 · 3 comments · Fixed by #6489
Closed

[EuiColorStops] Beginning from empty should look more empty #2876

cchaos opened this issue Feb 19, 2020 · 3 comments · Fixed by #6489
Assignees

Comments

@cchaos
Copy link
Contributor

cchaos commented Feb 19, 2020

image

Beginning and end transition colors: This is intentional. I'm having trouble finding the conversation, but it boils down to is that each color thumb is the start of a new color. Before a thumb, it is either the previous color or empty/gray. After a thumb, that color goes to infinity or until the next thumb.

Yep. This was a valid request from Maps. They have situations where the color doesn't start until a certain point. The best way to illustrate that was to use gray since that felt "disabled"

Originally posted by @snide in #2850 (comment)

@cchaos
Copy link
Contributor Author

cchaos commented Feb 19, 2020

Perhaps the gray needs to either be a lighter shade or the bar should be hollow (border only). I'm just not getting "disabled" with it. It looks like a full color, and I understand it has to be that dark for contrast.

@snide
Copy link
Contributor

snide commented Feb 19, 2020

I like the hollow idea. I think it might be really tricky to do from a css perspective. I'd opt for the lighter shade answer as an easy-to-do solution.

@cchaos cchaos changed the title [Discuss] Beginning colors of EuiColorStops [EuiColorStops] Beginning from empty should look more empty Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants