Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuggest] keyboard navigation issues #4345

Closed
alexwizp opened this issue Dec 4, 2020 · 3 comments · Fixed by #5157
Closed

[EuiSuggest] keyboard navigation issues #4345

alexwizp opened this issue Dec 4, 2020 · 3 comments · Fixed by #5157

Comments

@alexwizp
Copy link
Contributor

alexwizp commented Dec 4, 2020

During real-world testing of this component, we found a couple of keyboard issues that should probably be addressed on the component side

  • We should keep focus on input component after selecting something from the suggestions list.
    test case:
    1. start typing to open a list of suggestions
    2. press Tab to select first item from the list
    3. press Enter to apply suggestion.
    4. continue typing

Screen Recording 2020-12-04 at 12 34 21 PM

Expected behavior: Focus should be on Input control. User should be able to continue typing

  • In case of no suggestions we need don't need to set focus on empty list
    1. fill control with text without suggestions
    2. press Tab button

Screen Recording 2020-12-04 at 12 42 52 PM

Expected behavior: Focus should be on next form control. It's probably true, but if I select somewhere in form focus returned back to EuiSuggest.

@thompsongl
Copy link
Contributor

#4302 and #3733 discuss this more completely, but we are tracking that EuiSuggest will be refactored in the future.

@ryankeairns
Copy link
Contributor

FYI, the EuiSuggest component is being used in this PR, so this issue resurfaced.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants