Deprecate all usages of secondary as a color type

[cchaos]

#4874 Does this for all of our buttons, but there are still other usages like in EuiExpression and EuiBadge. We should get to a better consistency across the board and add success while deprecating secondary.

For someone who takes this on, you can see the referenced issue as an example.

[babs20]

Hello! Can I be assigned to this issue?

[cchaos]

👋 Welcome @babs20! Feel free to tackle any of the github issues (good first issues are especially great to grab). For more contribution guidance, you can read through the CONTRIBUTING doc. I'll also specifically point out that we don't "assign" issues to community members, but you're always welcome to "claim" it 😉 .

[cchaos]

I also want to point out that specifically for this issue, we don't want to remove the secondary options just yet. We just need to be sure we add success where we currently support secondary, and add a deprecation notice in the props comment like this:

eui/src/components/button/button.tsx

Lines 91 to 94 in 845cacb

	* Any of our named colors.
	* **`secondary` color is DEPRECATED, use `success` instead**
	*/
	color?: ButtonColor;

[babs20]

I'll also specifically point out that we don't "assign" issues to community members, but you're always welcome to "claim" it 😉 .

Sounds good, and thanks for letting me know!

I also want to point out that specifically for this issue, we don't want to remove the secondary options just yet. We just need to be sure we add success where we currently support secondary, and add a deprecation notice in the props comment like this:

eui/src/components/button/button.tsx

Lines 91 to 94 in 845cacb

	* Any of our named colors.
	* **`secondary` color is DEPRECATED, use `success` instead**
	*/
	color?: ButtonColor;

Thanks for the heads up! I will keep this in mind.