Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiLoading components are no longer animated if the browser has no prefers-reduced-motion support #4887

Closed
wenchonglee opened this issue Jun 16, 2021 · 1 comment

Comments

@wenchonglee
Copy link
Contributor

Hey,

This is a weird one. I received feedback from someone using Chrome version 73 that the loading components are no longer animated.

Problems with older browsers are always a pain (why wouldn't you just update the browser?!)
I later managed to reproduce this using the browserling web app that emulates older browsers, you can see that the loading icons are stuck in place and not animated.

I think this is due to the PR #4835 when prefers-reduced-motion was added into the mix, see MDN for the supported browsers. I can also confirm that the animations were running before this version was released.

Can I suggest that we keep animations for unsupported browsers?

@cchaos
Copy link
Contributor

cchaos commented Jun 16, 2021

Thanks for reporting this @wenchonglee. You are right in that it's specifically not supported in Chrome v. 73 and lower. We added this in as a direct enhancement to our accessibility goals and understood the implications of using a newer method.

We like to use CanIUse to see the breakdown of browser support, and unfortunately, v73 is already 2 years old and falls within only 1.2% of browser usages. Globally prefers-reduced-motion is supported by 91% of browsers being used. It is certainly a rare case, but we need to consider the maintenance costs of trying to support anything less than the latest 2 versions of current browsers.

Sorry we can't directly help your customer in this situation.

@cchaos cchaos closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants