Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Issues with minimal height when browser zoom lower than 100% #6581

Open
Tracked by #182611
dej611 opened this issue Feb 8, 2023 · 2 comments
Open
Tracked by #182611
Assignees
Labels
bug data grid ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@dej611
Copy link
Contributor

dej611 commented Feb 8, 2023

This issue is particularly bad when there's only 1 row to visualize on the data grid as the header takes up the full space.
As a user who always keep the zoom level at 80% during regular navigation this can be very annoying.

As an example in the Kibana Vega debug inspector the initial data grid contains only 1 row which is shown as follow with 100% zoom:
Screenshot 2023-02-08 at 12 00 23

If I set the browser zoom at 80% within the same session then I get this (which seems correct to me):
Screenshot 2023-02-08 at 12 02 12

If I refresh and reopen the same inspector page, then I get this instead:
Screenshot 2023-02-08 at 12 02 29

The general behaviour with 80% zoom set I see is a N-1 rows in the table which is not super bad, but with the 1 row this is really a bad issue. Perhaps a minimal height can be provided in this case? Or maybe take into account the devicePixelRatio when computing the grid height?

Kibana linked issue: elastic/kibana#148877

@cee-chen
Copy link
Member

cee-chen commented Feb 8, 2023

Hey @dej611! I can confirm/repro this issue - I actually normally browse on Firefox with a larger devPixelsPerPx than the default and have def run into this in the past in EUI's datagrid docs.

As a heads up, EuiDataGrid is currently lower on our priorities and roadmap, so I just wanted to let you know that we have no ETA for a fix and are unlikely to pick up this issue in the near future, but we'd absolutely welcome a PR for it. I think your point on using devicePixelRatio is right on the money.

@tkajtoch tkajtoch added the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Aug 5, 2024
@tkajtoch
Copy link
Member

tkajtoch commented Aug 5, 2024

Adding needs validation label back as we need to look into this issue again and understand if it's still happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data grid ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

4 participants